Add minimum Conetxt Menu

Add minimum Context Menu.

More menus will be added in separate CL.

BUG=380438
TEST=None
R=mukai@chromium.org,ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288346

[oshima, 2014-08-07 18:34:08]

mukai -> everything
ben -> DEPS change (ui/aura, components/web_modal)

[tfarina, 2014-08-07 18:42:04]

Fixed CL typo.

s/Conetxt/Context

[Jun Mukai, 2014-08-07 19:30:59]

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
File athena/content/render_view_context_menu_impl.cc (right):

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:48:
set_toolkit_delegate(delegate.Pass());
you can just call as:
set_toolkit_delegate(scoped_ptr<ToolkitDelegate>(new ToolkitDelegateViews)),
unnecessary to make a local variable.

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:58: ->RunMenuAt(parent, point,
type);
usually arrow operator appears at the end of the previous line?

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:69: void
RenderViewContextMenuImpl::RecordShownItem(int id) {
can you add a TODO comment to implement this?

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:72: void
RenderViewContextMenuImpl::RecordUsedItem(int id) {
ditto

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:80: void
RenderViewContextMenuImpl::NotifyMenuShown() {
ditto
or is it intentionally blank?

https://codereview.chromium.org/448063005/diff/100001/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/448063005/diff/100001/athena/main/athena_main...
athena/main/athena_main.cc:86: wm_state_.reset(new ::wm::WMState);
I think sadrul has added WMSate to window manager.  Do you really need this
here?

[oshima, 2014-08-07 20:23:07]

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
File athena/content/render_view_context_menu_impl.cc (right):

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:48:
set_toolkit_delegate(delegate.Pass());
On 2014/08/07 19:30:59, Jun Mukai wrote:
> you can just call as:
> set_toolkit_delegate(scoped_ptr<ToolkitDelegate>(new ToolkitDelegateViews)),
> unnecessary to make a local variable.

Done.

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:58: ->RunMenuAt(parent, point,
type);
On 2014/08/07 19:30:59, Jun Mukai wrote:
> usually arrow operator appears at the end of the previous line?

This is what git cl format does, and we decided to just use whatever
it does.

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:69: void
RenderViewContextMenuImpl::RecordShownItem(int id) {
On 2014/08/07 19:30:59, Jun Mukai wrote:
> can you add a TODO comment to implement this?

Done.

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:72: void
RenderViewContextMenuImpl::RecordUsedItem(int id) {
On 2014/08/07 19:30:59, Jun Mukai wrote:
> ditto

Done.

https://codereview.chromium.org/448063005/diff/100001/athena/content/render_v...
athena/content/render_view_context_menu_impl.cc:80: void
RenderViewContextMenuImpl::NotifyMenuShown() {
On 2014/08/07 19:30:58, Jun Mukai wrote:
> ditto
> or is it intentionally blank?

This is indeed intentionally blank. The chrome uses notification and it should
be replaced with something else (in which case, these will be removed)

https://codereview.chromium.org/448063005/diff/100001/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/448063005/diff/100001/athena/main/athena_main...
athena/main/athena_main.cc:86: wm_state_.reset(new ::wm::WMState);
On 2014/08/07 19:30:59, Jun Mukai wrote:
> I think sadrul has added WMSate to window manager.  Do you really need this
> here?

I didn't exist when I worked on it. thanks you for the info. removed.

[Jun Mukai, 2014-08-07 20:26:09]

lgtm

[Ben Goodger (Google), 2014-08-07 22:01:53]

lgtm

[oshima, 2014-08-07 22:02:21]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-07 22:21:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/448063005/120001

[oshima, 2014-08-07 23:37:01]

The CQ bit was unchecked by oshima@chromium.org

[oshima, 2014-08-08 09:51:34]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-08 09:54:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/448063005/120001

[commit-bot: I haz the power, 2014-08-08 14:02:17]

Change committed as 288346