Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 448063004: Make Element::synchronizeAllAttributes() private (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Make Element::synchronizeAllAttributes() private Make Element::synchronizeAllAttributes() private instead of public. Now that Element::attributes() calls synchronizeAllAttributes() internally, there is no reason for external code to call it. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/dom/Element.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 4 months ago (2014-08-07 17:32:36 UTC) #1
adamk
lgtm!
6 years, 4 months ago (2014-08-07 18:18:32 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-07 19:21:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/448063004/1
6 years, 4 months ago (2014-08-07 19:22:25 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 20:57:54 UTC) #5
Message was sent while issue was closed.
Change committed as 179752

Powered by Google App Engine
This is Rietveld 408576698