media: Fix not-thread-safe access to variables in android media code.

media: Fix not-thread-safe access to variables in android media code.

There are 3 big changes;
1. Initialize and bind StreamTextureProxy to the impl thread when the main
thread is blocked.
2. Set stream texture size when the video size is changed, instead of adhoc in
rendering code.
3. Add lots of thread checks.

BUG=N/A

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289315

[dshwang, 2014-08-07 07:10:55]

qinmin@, sievers@, could you review? IMO this CL can fix not-reproducible crash
bug in android.

[qinmin, 2014-08-08 22:02:58]

https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:1145:
stream_texture_proxy_->BindToCurrentThread(stream_id_);
I don't think this is correct, the stream_texture_proxy is created on main
thread, but lives on the compositor thread

[dshwang, 2014-08-09 06:01:26]

https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:1145:
stream_texture_proxy_->BindToCurrentThread(stream_id_);
On 2014/08/08 22:02:58, qinmin wrote:
> I don't think this is correct, the stream_texture_proxy is created on main
> thread, but lives on the compositor thread

As above comments, I bind the proxy to the compositor thread because only
compositor thread calls this method with client argument.

[qinmin, 2014-08-10 18:33:51]

lgtm

https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:1145:
stream_texture_proxy_->BindToCurrentThread(stream_id_);
i see, i missed the non-null check on client.

On 2014/08/09 06:01:26, dshwang wrote:
> On 2014/08/08 22:02:58, qinmin wrote:
> > I don't think this is correct, the stream_texture_proxy is created on main
> > thread, but lives on the compositor thread
> 
> As above comments, I bind the proxy to the compositor thread because only
> compositor thread calls this method with client argument.

[dshwang, 2014-08-11 08:03:45]

On 2014/08/10 18:33:51, qinmin wrote:
> lgtm
> 
>
https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
> File content/renderer/media/android/webmediaplayer_android.cc (right):
> 
>
https://codereview.chromium.org/448063003/diff/1/content/renderer/media/andro...
> content/renderer/media/android/webmediaplayer_android.cc:1145:
> stream_texture_proxy_->BindToCurrentThread(stream_id_);
> i see, i missed the non-null check on client.
> 
> On 2014/08/09 06:01:26, dshwang wrote:
> > On 2014/08/08 22:02:58, qinmin wrote:
> > > I don't think this is correct, the stream_texture_proxy is created on main
> > > thread, but lives on the compositor thread
> > 
> > As above comments, I bind the proxy to the compositor thread because only
> > compositor thread calls this method with client argument.

Thank you for review!

[dshwang, 2014-08-11 08:07:40]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2014-08-11 08:08:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/448063003/1

[commit-bot: I haz the power, 2014-08-11 08:16:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/39863)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/45108)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-11 08:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 08:18:00]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/39868)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dshwang, 2014-08-11 08:43:17]

https://codereview.chromium.org/448063003/diff/20001/content/renderer/media/a...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/448063003/diff/20001/content/renderer/media/a...
content/renderer/media/android/webmediaplayer_android.cc:813: if (!is_remote_ &&
cached_stream_texture_size_ != natural_size_) {
qinmin@, could you review this part again?
Previous patch has issue; if video size is change in remote mode,
WebMediaPlayerAndroid never report the size to stream texture although the mode
is changed to not-remote mode.

So I change to set the size in EstablishSurfaceTexturePeer() if needed.
WDYT?

[dshwang, 2014-08-13 12:42:40]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2014-08-13 12:44:00]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/448063003/60001

[commit-bot: I haz the power, 2014-08-13 13:54:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-13 13:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 13:58:16]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dshwang, 2014-08-13 16:17:00]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2014-08-13 16:18:15]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/448063003/60001

[commit-bot: I haz the power, 2014-08-13 16:29:12]

Committed patchset #3 (60001) as 289315