Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 448063002: ServiceWorker: Add layout test for worker script MIME type. (Closed)

Created:
6 years, 4 months ago by xiang
Modified:
6 years, 3 months ago
Reviewers:
falken, michaeln
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Add layout test for worker script MIME type. A worker script with invalid MIME type should not be registered. BUG=400604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181006

Patch Set 1 #

Patch Set 2 : simple rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M LayoutTests/http/tests/serviceworker/registration.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/serviceworker/resources/plain-text-worker.php View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
xiang
PTAL, thanks! BTW, I found the exception code is not match the spec(some AbortError should ...
6 years, 4 months ago (2014-08-07 05:20:07 UTC) #1
falken
Let me see if I understand. Fetching 'resources/plain-text-worker.php' returns an empty "service worker" with content-type ...
6 years, 4 months ago (2014-08-07 05:34:34 UTC) #2
xiang
On 2014/08/07 05:34:34, falken wrote: > Let me see if I understand. Fetching 'resources/plain-text-worker.php' returns ...
6 years, 4 months ago (2014-08-07 06:19:50 UTC) #3
falken
On 2014/08/07 06:19:50, xiang wrote: > On 2014/08/07 05:34:34, falken wrote: > > Let me ...
6 years, 4 months ago (2014-08-07 07:12:09 UTC) #4
jsbell
What's the status of this patch? Can we get this test landed? Anything I can ...
6 years, 3 months ago (2014-08-26 19:22:13 UTC) #5
xiang
The CQ bit was checked by xiang.long@intel.com
6 years, 3 months ago (2014-08-28 01:16:53 UTC) #6
xiang
The CQ bit was unchecked by xiang.long@intel.com
6 years, 3 months ago (2014-08-28 01:17:24 UTC) #7
xiang
The CQ bit was checked by xiang.long@intel.com
6 years, 3 months ago (2014-08-28 01:18:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiang.long@intel.com/448063002/20001
6 years, 3 months ago (2014-08-28 01:18:34 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 02:16:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181006

Powered by Google App Engine
This is Rietveld 408576698