Eliminate the dependency of Profile from TtsMessageFilter.

chrome/browser/speech/extension_api/tts_engine_extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/speech/extension_api/tts_engine_extension_api.h"
 
 #include <string>
 
 #include "base/json/json_writer.h"
 #include "base/values.h"
@@ skipping 216 matching lines @@
       extensions::ExtensionSystem::Get(profile)->extension_service();
   DCHECK(extension_service);
   extension_service->component_loader()
       ->AddChromeOsSpeechSynthesisExtension();
   return true;
 #else
   return false;
 #endif
 }
 
+Profile* TtsExtensionEngine::GetProfile(int render_process_id) {
+  content::RenderProcessHost* rph =
+      content::RenderProcessHost::FromID(render_process_id);
+  if (!rph)  // Guard against race conditions on RPH lifetime.
+    return NULL;
+
+  return Profile::FromBrowserContext(rph->GetBrowserContext());

[dmazzoni, 2014/08/11 07:23:09]

Perhaps converting from BrowserContext to Profile should be done elsewhere? This
should just return a BrowserContext.

[mrunal, 2014/08/11 23:25:07]

What's wrong with keeping it here? I agree TtsExtensionEngine is not the best
place for it considering it's not related to Extensions. May be I can create a
ChromeTtsControllerDelegate(derived from TtsControllerDelegate) which can
implement this GetProfile method but then it will be lone-method class as I
don't see any more methods going there. Any suggestions, Where do you think this
conversion should happen? 

[dmazzoni, 2014/08/12 06:16:01]

What's wrong is that this is an implementation of a virtual function defined in
tts_controller.h, which we want to move to content.
As an example, TtsExtensionEventHandler::OnTtsEvent currently takes the profile
from an utterance and uses that to fire an extension event. Instead, OnTtsEvent
could take the utterance's browser context and convert it to a profile just
before using it.

+}
+
 bool ExtensionTtsEngineSendTtsEventFunction::RunSync() {
   int utterance_id;
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &utterance_id));
 
   base::DictionaryValue* event;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &event));
 
   std::string event_type;
   EXTENSION_FUNCTION_VALIDATE(
       event->GetString(constants::kEventTypeKey, &event_type));
@@ skipping 51 matching lines @@
         utterance_id, TTS_EVENT_PAUSE, char_index, std::string());
   } else if (event_type == constants::kEventTypeResume) {
     controller->OnTtsEvent(
         utterance_id, TTS_EVENT_RESUME, char_index, std::string());
   } else {
     EXTENSION_FUNCTION_VALIDATE(false);
   }
 
   return true;
 }