Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5447)

Unified Diff: chrome/common/child_process_logging_win.cc

Issue 448006: Revert 33255 - Report active extensions in crash reports. This only implement... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/child_process_logging_win.cc
===================================================================
--- chrome/common/child_process_logging_win.cc (revision 33268)
+++ chrome/common/child_process_logging_win.cc (working copy)
@@ -7,7 +7,6 @@
#include <windows.h>
#include "base/string_util.h"
-#include "chrome/app/breakpad_win.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/installer/util/google_update_settings.h"
#include "googleurl/src/gurl.h"
@@ -19,10 +18,6 @@
// exported in breakpad_win.cc: void __declspec(dllexport) __cdecl SetClientId.
typedef void (__cdecl *MainSetClientId)(const wchar_t*);
-// exported in breakpad_win.cc:
-// void __declspec(dllexport) __cdecl SetExtensionID.
-typedef void (__cdecl *MainSetExtensionID)(size_t, const wchar_t*);
-
void SetActiveURL(const GURL& url) {
static MainSetActiveURL set_active_url = NULL;
// note: benign race condition on set_active_url.
@@ -66,24 +61,4 @@
(set_client_id)(wstr.c_str());
}
-void SetActiveExtensions(const std::vector<std::string>& extension_ids) {
- static MainSetExtensionID set_extension_id = NULL;
- if (!set_extension_id) {
- HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
- if (!exe_module)
- return;
- set_extension_id = reinterpret_cast<MainSetExtensionID>(
- GetProcAddress(exe_module, "SetExtensionID"));
- if (!set_extension_id)
- return;
- }
-
- for (size_t i = 0; i < kMaxReportedActiveExtensions; ++i) {
- if (i < extension_ids.size())
- (set_extension_id)(i, ASCIIToWide(extension_ids[i].c_str()).c_str());
- else
- (set_extension_id)(i, L"");
- }
-}
-
} // namespace child_process_logging
« no previous file with comments | « chrome/common/child_process_logging_mac.mm ('k') | chrome/renderer/extensions/extension_process_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698