Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 448006: Revert 33255 - Report active extensions in crash reports. This only implement... (Closed)

Created:
11 years ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Revert 33255 - Report active extensions in crash reports. This only implements Windows right now. Mac and linux will be separate CLs. "Active" is overloaded to mean different things depending on the process type: browser: all enabled extensions renderer: unique set of extensions from all user scripts extension: extensions running in the process BUG=27169 Review URL: http://codereview.chromium.org/437078 -- There are thousands of new crashes with reivison 33256 and 33255, so i'm reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -178 lines) Patch
M chrome/app/breakpad_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/breakpad_win.cc View 3 chunks +48 lines, -61 lines 0 comments Download
M chrome/browser/extensions/extensions_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/child_process_logging.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/common/child_process_logging_linux.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/renderer/user_script_slave.cc View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Sylvain
11 years ago (2009-11-30 05:07:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698