Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1730)

Issue 448004: Merge 32980 - o Updates the browser action buttons when a tab is changed. Thi... (Closed)

Created:
11 years ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Bons
CC:
chromium-reviews_googlegroups.com, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Merge 32980 - o Updates the browser action buttons when a tab is changed. This is needed for tabspecific browser action buttons. o If a tooltip is not present on a browser action button, clear the tooltip of the button. BUG=28719 TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab. Review URL: http://codereview.chromium.org/434047 TBR=andybons@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/browser/cocoa/extensions/browser_actions_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/extensions/browser_actions_controller.mm View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aaron Boodman
11 years ago (2009-11-30 02:48:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698