Get printer's paper size custom_display_name_localized property into account.

Get printer's paper size custom_display_name_localized property into account.

BUG=401344
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288402

[Vitaly Buka (NO REVIEWS), 2014-08-07 23:05:53]

lgtm

https://codereview.chromium.org/447963005/diff/1/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/settings/media_size_settings.js
(right):

https://codereview.chromium.org/447963005/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/settings/media_size_settings.js:75: var
getLocaleToCompare = function(locale, languageOnly) {
why not to put this function inside the next one?

https://codereview.chromium.org/447963005/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/settings/media_size_settings.js:82: if
(getLocaleToCompare(items[i].locale) == locale)
forEach

[Aleksey Shlyapnikov, 2014-08-08 00:25:49]

https://codereview.chromium.org/447963005/diff/1/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/settings/media_size_settings.js
(right):

https://codereview.chromium.org/447963005/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/settings/media_size_settings.js:75: var
getLocaleToCompare = function(locale, languageOnly) {
On 2014/08/07 23:05:52, Vitaly Buka wrote:
> why not to put this function inside the next one?

Less nesting, easier to read.

https://codereview.chromium.org/447963005/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/settings/media_size_settings.js:82: if
(getLocaleToCompare(items[i].locale) == locale)
On 2014/08/07 23:05:53, Vitaly Buka wrote:
> forEach

Nope, it won't work here. I need to stop and return from this function.

[Aleksey Shlyapnikov, 2014-08-08 00:25:59]

The CQ bit was checked by alekseys@chromium.org

[commit-bot: I haz the power, 2014-08-08 00:54:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alekseys@chromium.org/447963005/1

[commit-bot: I haz the power, 2014-08-08 05:21:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 05:42:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 05:42:31]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[Vitaly Buka (NO REVIEWS), 2014-08-08 18:45:25]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:47:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alekseys@chromium.org/447963005/1

[commit-bot: I haz the power, 2014-08-08 18:51:13]

Change committed as 288402