Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 447933002: DataReductionProxy.BypassedBytes.ShortAudioVideo UMA reports collateral damage (Closed)

Created:
6 years, 4 months ago by megjablon
Modified:
6 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing DataReductionProxy.BypassedBytes.ShortAudioVideo UMA. Currently the UMA tells us whenever audio/video is bypassed as collateral damage of a short bypass. We want to know when audio or video is the cause of a bypass so we now report to DataReductionProxy.BypassedBytes.ShortTriggeringRequestAudioVideo when audio or video triggers a bypass. BUG=401257 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289569

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Histograms.xml revert name #

Total comments: 2

Patch Set 3 : Fixed name in usage stats #

Patch Set 4 : Rebase and sync master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc View 1 2 3 1 chunk +12 lines, -10 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
megjablon
asvitkine: histograms.xml bengr: data_reduction_proxy_usage_stats.cc
6 years, 4 months ago (2014-08-06 21:57:27 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/447933002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/447933002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode49426 tools/metrics/histograms/histograms.xml:49426: - <suffix name="ShortAudioVideo" Was any data collected yet using ...
6 years, 4 months ago (2014-08-08 15:34:52 UTC) #2
megjablon
https://codereview.chromium.org/447933002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/447933002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode49426 tools/metrics/histograms/histograms.xml:49426: - <suffix name="ShortAudioVideo" On 2014/08/08 15:34:52, Alexei Svitkine wrote: ...
6 years, 4 months ago (2014-08-12 01:02:49 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/447933002/diff/40001/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc File components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc (right): https://codereview.chromium.org/447933002/diff/40001/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc#newcode196 components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc:196: "DataReductionProxy.BypassedBytes.ShortTriggeringRequestAudioVideo", Did you mean to not rename this?
6 years, 4 months ago (2014-08-12 14:32:37 UTC) #4
megjablon
On 2014/08/12 14:32:37, Alexei Svitkine wrote: > https://codereview.chromium.org/447933002/diff/40001/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc > File components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc > (right): > > ...
6 years, 4 months ago (2014-08-12 16:50:09 UTC) #5
megjablon
https://codereview.chromium.org/447933002/diff/40001/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc File components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc (right): https://codereview.chromium.org/447933002/diff/40001/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc#newcode196 components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc:196: "DataReductionProxy.BypassedBytes.ShortTriggeringRequestAudioVideo", On 2014/08/12 14:32:37, Alexei Svitkine wrote: > Did ...
6 years, 4 months ago (2014-08-12 16:53:59 UTC) #6
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-12 18:21:31 UTC) #7
bengr
On 2014/08/12 18:21:31, Alexei Svitkine wrote: > lgtm lgtm.
6 years, 4 months ago (2014-08-14 01:34:07 UTC) #8
megjablon
The CQ bit was checked by megjablon@chromium.org
6 years, 4 months ago (2014-08-14 01:35:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/megjablon@chromium.org/447933002/60001
6 years, 4 months ago (2014-08-14 01:37:41 UTC) #10
megjablon
The CQ bit was checked by megjablon@chromium.org
6 years, 4 months ago (2014-08-14 06:24:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/megjablon@chromium.org/447933002/80001
6 years, 4 months ago (2014-08-14 06:27:53 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 12:31:26 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 14:43:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (80001) as 289569

Powered by Google App Engine
This is Rietveld 408576698