Open source Cookie.* histograms.

Open source Cookie.* histograms.

BUG=223859
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287906

[Alexei Svitkine (slow), 2014-08-06 21:28:51]

Mechanical move of all the Cookie.* histograms in the closed-source
histograms.xml file to here.

[Ilya Sherman, 2014-08-06 21:30:54]

Thanks!  Can you link me to the inverse patch that removes the histograms from
the internal file?  It's easiest to review these in pairs, to confirm that the
changes are in fact inverses of one another :)

[Ilya Sherman, 2014-08-06 21:31:22]

https://codereview.chromium.org/447923002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/447923002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:2959: +<histogram
name="Cookie.BackingStoreUpdateResults" enum="BackingStoreResults">
Do you need to transfer over any enums or histogram_suffixes sections as well?

[Alexei Svitkine (slow), 2014-08-06 21:32:43]

Just sent, http://CL/72757551


On Wed, Aug 6, 2014 at 5:30 PM, <isherman@chromium.org> wrote:

> Thanks!  Can you link me to the inverse patch that removes the histograms
> from
> the internal file?  It's easiest to review these in pairs, to confirm that
> the
> changes are in fact inverses of one another :)
>
> https://codereview.chromium.org/447923002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2014-08-06 21:34:28]

https://codereview.chromium.org/447923002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/447923002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:2959: +<histogram
name="Cookie.BackingStoreUpdateResults" enum="BackingStoreResults">
On 2014/08/06 21:31:22, Ilya Sherman wrote:
> Do you need to transfer over any enums or histogram_suffixes sections as well?

Looks like all the enums used by these were already in this file.

[Ilya Sherman, 2014-08-06 21:36:10]

LGTM, thanks.

[Alexei Svitkine (slow), 2014-08-06 21:36:25]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2014-08-06 21:38:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/asvitkine@chromium.org/447923002/1

[commit-bot: I haz the power, 2014-08-07 00:06:05]

Change committed as 287906