Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Issue 447903003: Autofill: improve GetCreditCardSuggestions (Closed)

Created:
6 years, 4 months ago by Evan Stade
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Autofill: improve GetCreditCardSuggestions BUG=401286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288475

Patch Set 1 #

Total comments: 4

Patch Set 2 : isherman review #

Patch Set 3 : ah so there were tests after all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -13 lines) Patch
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 1 chunk +11 lines, -4 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Evan Stade
6 years, 4 months ago (2014-08-06 23:24:18 UTC) #1
Ilya Sherman
Thanks, Evan :) https://codereview.chromium.org/447903003/diff/1/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://codereview.chromium.org/447903003/diff/1/components/autofill/core/browser/personal_data_manager.cc#newcode686 components/autofill/core/browser/personal_data_manager.cc:686: } Please include comments explaining the ...
6 years, 4 months ago (2014-08-06 23:32:10 UTC) #2
Evan Stade
https://codereview.chromium.org/447903003/diff/1/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://codereview.chromium.org/447903003/diff/1/components/autofill/core/browser/personal_data_manager.cc#newcode686 components/autofill/core/browser/personal_data_manager.cc:686: } On 2014/08/06 23:32:09, Ilya Sherman wrote: > Please ...
6 years, 4 months ago (2014-08-07 00:05:02 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 4 months ago (2014-08-07 00:05:05 UTC) #4
Evan Stade
The CQ bit was unchecked by estade@chromium.org
6 years, 4 months ago (2014-08-07 00:05:09 UTC) #5
Ilya Sherman
LGTM, thanks.
6 years, 4 months ago (2014-08-07 00:34:41 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-07 00:34:45 UTC) #7
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 4 months ago (2014-08-07 00:34:57 UTC) #8
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 4 months ago (2014-08-08 19:51:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/447903003/40001
6 years, 4 months ago (2014-08-08 19:53:05 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 00:23:02 UTC) #11
Message was sent while issue was closed.
Change committed as 288475

Powered by Google App Engine
This is Rietveld 408576698