chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 447893003: Test that simulates touch exploration and checks speech on tabs and also the empty bookmark bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 447893003: Test that simulates touch exploration and checks speech on tabs and also the empty bookmark bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: check for existing window.ontouchstart Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/accessibility/spoken_feedback_views_browsertest.cc ('K') | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.h ('k') | chrome/chrome_tests.gypi » ('j') | chrome/chrome_tests.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index 7292a6e0a9ff2791a6806ee134786a8a389f40bb..a44d2edb13aaa4ccc9c64ee0cd15a7f7819f8f02 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -626,6 +626,12 @@ views::MenuItemView* BookmarkBarView::GetDropMenu() {

return bookmark_drop_menu_ ? bookmark_drop_menu_->menu() : NULL;

}

+views::View* BookmarkBarView::GetBookmarkBarInstructionsView() {

+ if (instructions_ && instructions_->visible())

+ return instructions_;

+ return NULL;

void BookmarkBarView::StopThrobbing(bool immediate) {

if (!throbbing_view_)

return;