chrome/browser/chromeos/accessibility/accessibility_util.cc - Issue 447893003: Test that simulates touch exploration and checks speech on tabs and also the empty bookmark bar.

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_util.cc

Issue 447893003: Test that simulates touch exploration and checks speech on tabs and also the empty bookmark bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: check for existing window.ontouchstart Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/accessibility/accessibility_util.h ('K') | « chrome/browser/chromeos/accessibility/accessibility_util.h ('k') | chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc » ('j') | chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/accessibility/accessibility_util.cc

diff --git a/chrome/browser/chromeos/accessibility/accessibility_util.cc b/chrome/browser/chromeos/accessibility/accessibility_util.cc

index 3d2d95d4a1f146a7b5c19e0515ed3129079ba6ff..16bd4df85609a89cd69928957003a4244423db02 100644

--- a/chrome/browser/chromeos/accessibility/accessibility_util.cc

+++ b/chrome/browser/chromeos/accessibility/accessibility_util.cc

@@ -7,8 +7,13 @@

#include "base/prefs/pref_service.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/ui/singleton_tabs.h"

+#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

+#include "content/public/test/browser_test_utils.h"

+#include "extensions/browser/extension_host.h"

+#include "extensions/browser/extension_system.h"

+#include "extensions/browser/process_manager.h"

#include "url/gurl.h"

// TODO(yoshiki): move the following method to accessibility_manager.cc and

@@ -38,5 +43,20 @@ void ShowAccessibilityHelp(Browser* browser) {

chrome::ShowSingletonTab(browser, GURL(chrome::kChromeAccessibilityHelpURL));

}

+void SimulateTouchScreenInChromeVoxForTest(content::BrowserContext* profile) {

+ // ChromeVox looks at whether 'ontouchstart' exists to know whether

+ // or not it should respond to hover events. Fake it so that touch

+ // exploration events get spoken.

+ extensions::ExtensionHost* host =

+ extensions::ExtensionSystem::Get(profile)

+ ->process_manager()

+ ->GetBackgroundHostForExtension(

+ extension_misc::kChromeVoxExtensionId);

+ CHECK(content::ExecuteScript(

+ host->host_contents(),

+ "if (!('ontouchstart' in window)) window.ontouchstart = function() {};"));

James Cook 2014/08/08 20:26:46 You should make sure these tests still pass with t

evy 2014/08/08 21:00:29 They do still pass. Should I keep the change or le

} // namespace accessibility

} // namespace chromeos