Test that simulates touch exploration and checks speech on tabs and also the empty bookmark bar.

chrome/browser/ui/views/accessibility/spoken_feedback_chromeos_browsertest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.

[James Cook, 2014/08/08 17:06:32]

I steered you wrong. This should be spoken_feedback_views_browsertest.cc like I
initially suggested. (I forgot the other file was
spoken_feedback_browsertest.cc)

[evy, 2014/08/08 18:37:47]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/strings/string_util.h"
+#include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
+#include "chrome/browser/chromeos/accessibility/accessibility_util.h"
+#include "chrome/browser/chromeos/accessibility/speech_monitor.h"
+#include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/tabs/tab_strip.h"
+#include "chrome/test/base/in_process_browser_test.h"
+
+typedef InProcessBrowserTest SpokenFeedbackViewsTest;

[James Cook, 2014/08/08 17:06:32]

Add a brief comment about why this lives in c/b/ui/views 

[evy, 2014/08/08 18:37:47]

Done.

+
+namespace chromeos {
+
+IN_PROC_BROWSER_TEST_F(SpokenFeedbackViewsTest,

[James Cook, 2014/08/08 17:06:32]

Add a brief comment explaining what you are testing.

[evy, 2014/08/08 18:37:47]

Done.

+                       TouchExploreBookmarkBarInstructions) {
+  EXPECT_FALSE(AccessibilityManager::Get()->IsSpokenFeedbackEnabled());

[James Cook, 2014/08/08 17:06:32]

I would ASSERT_FALSE, as this is a precondition for the test.

[evy, 2014/08/08 18:37:47]

Done.

+  SpeechMonitor monitor;
+  AccessibilityManager::Get()->EnableSpokenFeedback(
+      true, ash::A11Y_NOTIFICATION_NONE);
+  EXPECT_TRUE(monitor.SkipChromeVoxEnabledMessage());
+
+  accessibility::SimulateTouchScreenInChromeVoxForTest(browser()->profile());
+
+  // Send an accessibility hover event on the empty bookmarks bar, which is
+  // what we get when you tap it on a touch screen when ChromeVox is on.
+  BrowserView* browser_view =
+      static_cast<BrowserView*>(browser()->window());
+  BookmarkBarView* bookmarks_bar = browser_view->GetBookmarkBarView();
+  views::View* instructions = bookmarks_bar->GetBookmarkBarInstructionsView();
+  instructions->NotifyAccessibilityEvent(ui::AX_EVENT_HOVER, true);
+
+  EXPECT_EQ("Bookmarks,", monitor.GetNextUtterance());
+  EXPECT_EQ("For quick access,", monitor.GetNextUtterance());

[aboxhall, 2014/08/08 17:16:01]

Possibly consider expressing this in terms of instructions->text()
(You'd have to split the string up yourself though; possibly not worth it - it
would just mean the test wouldn't break if they changed the wording at some
point.)

[evy, 2014/08/08 18:37:47]

I thought a bit about that, and I'm glad you brought it up - I think it's hard
to know for sure how it's broken up (more of a guess and check)
Dominic suggested to just do this, so I think I'll stick with it, but I'm not
set on that decision. 
Let me know if you think it'd be better to break up the instruction accessible
name string.

[aboxhall, 2014/08/08 20:01:52]

I think on balance it'd probably be over-engineering it; you'd also have to get
the "Bookmarks" utterance which would be from
bookmarks_bar->GetAccessibleState(), and I'm not sure whether that method ends
up including the label contents or not... so I think this is fine for now; if it
breaks we'll just cross that bridge!

[evy, 2014/08/08 21:00:28]

Acknowledged.

+  EXPECT_EQ("place your bookmarks here on the bookmarks bar.",
+            monitor.GetNextUtterance());
+}
+
+IN_PROC_BROWSER_TEST_F(SpokenFeedbackViewsTest, TouchExploreTabs) {
+  EXPECT_FALSE(AccessibilityManager::Get()->IsSpokenFeedbackEnabled());
+  SpeechMonitor monitor;
+  AccessibilityManager::Get()->EnableSpokenFeedback(
+      true, ash::A11Y_NOTIFICATION_NONE);
+  EXPECT_TRUE(monitor.SkipChromeVoxEnabledMessage());
+
+  accessibility::SimulateTouchScreenInChromeVoxForTest(browser()->profile());
+
+  // Send an accessibility hover event on a tab in the tap strip, which is
+  // what we get when you tap it on a touch screen when ChromeVox is on.
+  BrowserView* browser_view =
+      static_cast<BrowserView*>(browser()->window());
+  TabStrip* tab_strip = browser_view->tabstrip();
+  ASSERT_EQ(tab_strip->tab_count(), 1);
+
+  Tab* tab = tab_strip->tab_at(0);
+  tab->NotifyAccessibilityEvent(ui::AX_EVENT_HOVER, true);
+  EXPECT_TRUE(MatchPattern(monitor.GetNextUtterance(), "*, tab * of *"));
+}
+
+}  // namespace chromeos