chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc - Issue 447873004: [Password Generation] Wait longer to dismiss suggestion UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 447873004: [Password Generation] Wait longer to dismiss suggestion UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/password_generation_popup_controller_impl.h ('k') | chrome/renderer/autofill/password_generation_agent_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

index 747b9a523b692096f33aec01a012bdada889eebb..db3f0a0448a81cfea6e15b411b8471e81474a787 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

@@ -173,7 +173,7 @@ void PasswordGenerationPopupControllerImpl::CalculateBounds() {

void PasswordGenerationPopupControllerImpl::Show(bool display_password) {

display_password_ = display_password;

- if (display_password_)

+ if (display_password_ && current_password_.empty())

current_password_ = base::ASCIIToUTF16(generator_->Generate());

if (!view_) {