[Password Generation] Wait longer to dismiss suggestion UI

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
@@ skipping 40 matching lines @@
     AutofillMsg_AccountCreationFormsDetected msg(0, forms);
     password_generation_->OnMessageReceived(msg);
   }
 
   void ExpectPasswordGenerationAvailable(const char* element_id,
                                          bool available) {
     WebDocument document = GetMainFrame()->document();
     WebElement element =
         document.getElementById(WebString::fromUTF8(element_id));
     ASSERT_FALSE(element.isNull());
-    WebInputElement target_element = element.to<WebInputElement>();
     ExecuteJavaScript(
         base::StringPrintf("document.getElementById('%s').focus();",
                            element_id).c_str());
     if (available) {
       ASSERT_EQ(1u, password_generation_->messages().size());
       EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
                 password_generation_->messages()[0]->type());
     } else {
       EXPECT_EQ(0u, password_generation_->messages().size());
     }
@@ skipping 177 matching lines @@
   ExpectPasswordGenerationAvailable("first_password", false);
 
   // Receive the account creation forms detected message. Show password
   // generation icon.
   LoadHTML(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(kAccountCreationFormHTML);
   ExpectPasswordGenerationAvailable("first_password", true);
 }
 
+TEST_F(PasswordGenerationAgentTest, MaximumOfferSize) {
+  LoadHTML(kAccountCreationFormHTML);
+  SetNotBlacklistedMessage(kAccountCreationFormHTML);
+  SetAccountCreationFormsDetectedMessage(kAccountCreationFormHTML);
+  ExpectPasswordGenerationAvailable("first_password", true);
+
+  WebDocument document = GetMainFrame()->document();
+  WebElement element =
+      document.getElementById(WebString::fromUTF8("first_password"));
+  ASSERT_FALSE(element.isNull());
+  WebInputElement first_password_element = element.to<WebInputElement>();
+
+  // Make a password small just under maximum offer size.

[Ilya Sherman, 2014/08/06 22:25:08]

nit: This wording feels a little odd.  Mind rephrasing?

[Garrett Casto, 2014/08/08 18:19:19]

Typo, cleaned up.

+  first_password_element.setValue(
+      base::ASCIIToUTF16(
+          std::string(password_generation_->kMaximumOfferSize - 1, 'a')));
+  // Cast to WebAutofillClient where textFieldDidChange() is public.
+  static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
+      first_password_element);
+  // textFieldDidChange posts a task, so we need to wait until it's been
+  // processed.
+  base::MessageLoop::current()->RunUntilIdle();
+  // There should now be a message to show the UI.
+  ASSERT_EQ(1u, password_generation_->messages().size());
+  EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
+            password_generation_->messages()[0]->type());
+  password_generation_->clear_messages();
+
+  // Simulate a user typing a password just over maximum offer size.
+  first_password_element.setValue(
+      base::ASCIIToUTF16(
+          std::string(password_generation_->kMaximumOfferSize + 1, 'a')));

[Ilya Sherman, 2014/08/06 22:25:08]

You have tests for |kMaximumOfferSize - 1| and |kMaximumOfferSize + 1|, but none
for equal to |kMaximumOfferSize| exactly.

[Garrett Casto, 2014/08/08 18:19:19]

Done.

+  // Cast to WebAutofillClient where textFieldDidChange() is public.
+  static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
+      first_password_element);
+  // textFieldDidChange posts a task, so we need to wait until it's been
+  // processed.
+  base::MessageLoop::current()->RunUntilIdle();
+  // There should now be a message to hide the UI.
+  ASSERT_EQ(1u, password_generation_->messages().size());
+  EXPECT_EQ(AutofillHostMsg_HidePasswordGenerationPopup::ID,
+            password_generation_->messages()[0]->type());
+  password_generation_->clear_messages();
+
+  // Simulate the user deleting characters. The generation popup should be shown
+  // again.
+  first_password_element.setValue(
+      base::ASCIIToUTF16(
+          std::string(password_generation_->kMaximumOfferSize - 1, 'a')));
+  // Cast to WebAutofillClient where textFieldDidChange() is public.
+  static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
+      first_password_element);
+  // textFieldDidChange posts a task, so we need to wait until it's been
+  // processed.
+  base::MessageLoop::current()->RunUntilIdle();
+  // There should now be a message to show the UI.
+  ASSERT_EQ(1u, password_generation_->messages().size());
+  EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
+            password_generation_->messages()[0]->type());
+}
+
 }  // namespace autofill