Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 447803002: On the bots, there's no need to link GMs into SampleApp. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

On the bots, there's no need to link GMs into SampleApp. We build SampleApp on the bots to make sure it's not broken, but we don't run it. So, there's no need to link in all the GMs as samples. This reduces the number of copies of our GMs from 4 to 3 (gm, dm, and nanobench remain). NOTREECHECKS=true BUG=skia:2142 Committed: https://skia.googlesource.com/skia/+/a7e930f640b8757686650384761ecff117b46bd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -191 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_variables.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +188 lines, -188 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 4 months ago (2014-08-06 16:50:02 UTC) #1
bsalomon
lgtm
6 years, 4 months ago (2014-08-06 16:54:53 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-06 16:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/447803002/1
6 years, 4 months ago (2014-08-06 16:56:17 UTC) #4
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 4 months ago (2014-08-06 17:01:23 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-06 17:01:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/447803002/1
6 years, 4 months ago (2014-08-06 17:01:37 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 17:08:48 UTC) #8
Message was sent while issue was closed.
Change committed as a7e930f640b8757686650384761ecff117b46bd2

Powered by Google App Engine
This is Rietveld 408576698