VM: Micro-optimization of inline array allocation code.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 2075 matching lines @@
   // Set the length field.
   __ StoreIntoObjectNoBarrier(EAX,
                               FieldAddress(EAX, Array::length_offset()),
                               kLengthReg);
 
   // Initialize all array elements to raw_null.
   // EAX: new object start as a tagged pointer.
   // EBX: new object end address.
   // EDI: iterator which initially points to the start of the variable
   // data area to be initialized.
-  const Immediate& raw_null =
-      Immediate(reinterpret_cast<intptr_t>(Object::null()));
-  __ leal(EDI, FieldAddress(EAX, sizeof(RawArray)));
-  Label init_loop;
-  __ Bind(&init_loop);
-  __ cmpl(EDI, EBX);
-  __ j(ABOVE_EQUAL, done, Assembler::kNearJump);
-  __ movl(Address(EDI, 0), raw_null);
-  __ addl(EDI, Immediate(kWordSize));
-  __ jmp(&init_loop, Assembler::kNearJump);
+  if (num_elements > 0) {
+    const Immediate& raw_null =
+        Immediate(reinterpret_cast<intptr_t>(Object::null()));
+    __ leal(EDI, FieldAddress(EAX, sizeof(RawArray)));
+    Label init_loop;
+    __ Bind(&init_loop);
+    __ movl(Address(EDI, 0), raw_null);
+    __ addl(EDI, Immediate(kWordSize));
+    __ cmpl(EDI, EBX);
+    __ j(BELOW, &init_loop, Assembler::kNearJump);
+  }
+  __ jmp(done, Assembler::kNearJump);
 }
 
 
 void CreateArrayInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   // Allocate the array.  EDX = length, ECX = element type.
   const Register kLengthReg = EDX;
   const Register kElemTypeReg = ECX;
   const Register kResultReg = EAX;
   ASSERT(locs()->in(0).reg() == kElemTypeReg);
   ASSERT(locs()->in(1).reg() == kLengthReg);
@@ skipping 4441 matching lines @@
   __ movl(EDX, Immediate(kInvalidObjectPointer));
   __ movl(EDX, Immediate(kInvalidObjectPointer));
 #endif
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_IA32