Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 447783003: Remove service worker concepts from apps/extensions manifest parsing. (Closed)

Created:
6 years, 4 months ago by scheib
Modified:
6 years, 3 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove service worker concepts from apps/extensions manifest parsing. BUG=396340 Committed: https://crrev.com/02ad1a725586f0b28e30511b63a3ffd068944eb4 Cr-Commit-Position: refs/heads/master@{#292187}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -215 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/common/manifest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M extensions/common/manifest_constants.cc View 1 3 chunks +0 lines, -7 lines 0 comments Download
M extensions/common/manifest_handlers/background_info.h View 3 chunks +0 lines, -11 lines 0 comments Download
M extensions/common/manifest_handlers/background_info.cc View 8 chunks +9 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scheib
6 years, 4 months ago (2014-08-06 16:45:37 UTC) #1
scheib
6 years, 3 months ago (2014-08-27 16:29:10 UTC) #2
Jeffrey Yasskin
lgtm
6 years, 3 months ago (2014-08-27 16:39:01 UTC) #3
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 3 months ago (2014-08-27 16:59:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/447783003/20001
6 years, 3 months ago (2014-08-27 17:00:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 033f5f50b001a20585d4ab9ced9610d8f357eeae
6 years, 3 months ago (2014-08-27 18:21:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02ad1a725586f0b28e30511b63a3ffd068944eb4
Cr-Commit-Position: refs/heads/master@{#292187}

Powered by Google App Engine
This is Rietveld 408576698