Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 447753003: SkPicture: try to no-op away clone(). (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkPicture: try to no-op away clone(). Will actually enable this by #defining SK_PICTURE_CLONE_NOOP in Chrome's SkUserConfig.h as a separate CL after this rolls in. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3ba15ae3e13a6da0a9735fcc04166ed4d3ddcd67

Patch Set 1 #

Patch Set 2 : new flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/core/SkPicture.cpp View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 4 months ago (2014-08-06 18:41:01 UTC) #1
reed1
lgtm
6 years, 4 months ago (2014-08-06 18:42:38 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-06 18:48:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/447753003/20001
6 years, 4 months ago (2014-08-06 18:49:58 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 18:57:14 UTC) #5
Message was sent while issue was closed.
Change committed as 3ba15ae3e13a6da0a9735fcc04166ed4d3ddcd67

Powered by Google App Engine
This is Rietveld 408576698