LayoutTests/inspector/documentation-url-provider.html - Issue 447703002: DocumentationURLProvider class created

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/documentation-url-provider.html

Issue 447703002: DocumentationURLProvider class created (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@semen

Patch Set: Tests added; rebased on 444883003 issue Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../http/tests/inspector/inspector-test.js"></script>

	4 <script>

	5

	6 function test()

	7 {

	8 WebInspector.moduleManager.registerModule("documentation");

	9 WebInspector.moduleManager.loadModule("documentation");

	10 var testCases = [

	11 "max",

	12 "insertBefore",

	13 "eval",

	14 "stringify",

	15 "isArray",

	16 "now",

	17 "fromCharCode",
	lushnikov 2014/08/06 17:27:51 These are all methods that exist. Let's add some t These are all methods that exist. Let's add some that don't and verify that DocumentationURLProvider doesn't crash in this case. semeny 2014/08/07 09:57:08 Done. Show quoted text On 2014/08/06 17:27:51, lushnikov wrote: > These are all methods that exist. Let's add some that don't and verify that > DocumentationURLProvider doesn't crash in this case. Done.
	18 "keys"];
	lushnikov 2014/08/06 17:27:51 "];" on a new line "];" on a new line semeny 2014/08/07 09:57:08 Done. Show quoted text On 2014/08/06 17:27:51, lushnikov wrote: > "];" on a new line Done.
	19 for (var i = 0; i < testCases.length; i++) {
	lushnikov 2014/08/06 17:27:51 ++i ++i semeny 2014/08/07 09:57:08 Done. Show quoted text On 2014/08/06 17:27:51, lushnikov wrote: > ++i Done.
	20 var urlFormer = new WebInspector.DocumentationURLProvider();
	lushnikov 2014/08/06 17:27:51 do we really need to recreate it for every for-loo do we really need to recreate it for every for-loop iteration? semeny 2014/08/07 09:57:08 Done. Show quoted text On 2014/08/06 17:27:51, lushnikov wrote: > do we really need to recreate it for every for-loop iteration? Done.
	21 InspectorTest.addResult("Property " + testCases[i] + ":");

	22 InspectorTest.addResult(urlFormer.formItemPath(testCases[i]));

	23 }

	24 InspectorTest.completeTest();

	25 }

	26

	27 </script>

	28 </head>

	29 <body onload="runTest()">
	lushnikov 2014/08/06 17:27:51 We usually add a short test description in <body> We usually add a short test description in <body> tag. (see examples in different tests) semeny 2014/08/07 09:57:08 Done. Show quoted text On 2014/08/06 17:27:51, lushnikov wrote: > We usually add a short test description in <body> tag. (see examples in > different tests) Done.
	30 </body>

	31 </html>

OLD	NEW