Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10292)

Unified Diff: chrome/installer/gcapi/gcapi.cc

Issue 447673004: Use CommandLine when launching Chrome from gcapi. Path may contain spaces for some partners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/gcapi/gcapi.cc
diff --git a/chrome/installer/gcapi/gcapi.cc b/chrome/installer/gcapi/gcapi.cc
index 0606988ab836cc22cb9d9bab764fbd865713872e..72539355215df7b66a0444255bb0dd32590e882f 100644
--- a/chrome/installer/gcapi/gcapi.cc
+++ b/chrome/installer/gcapi/gcapi.cc
@@ -503,18 +503,21 @@ BOOL __stdcall LaunchGoogleChrome() {
}
}
+ CommandLine chrome_command(chrome_exe_path);
+
bool ret = false;
ScopedComPtr<IProcessLauncher> ipl;
if (SUCCEEDED(ipl.CreateInstance(__uuidof(ProcessLauncherClass),
NULL,
CLSCTX_LOCAL_SERVER))) {
- if (SUCCEEDED(ipl->LaunchCmdLine(chrome_exe_path.value().c_str())))
+ if (SUCCEEDED(ipl->LaunchCmdLine(
+ chrome_command.GetCommandLineString().c_str())))
ret = true;
ipl.Release();
} else {
// Couldn't get Omaha's process launcher, Omaha may not be installed at
// system level. Try just running Chrome instead.
- ret = base::LaunchProcess(chrome_exe_path.value(),
+ ret = base::LaunchProcess(chrome_command.GetCommandLineString(),
base::LaunchOptions(),
NULL);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698