Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 447673004: Use CommandLine when launching Chrome from gcapi. Path may contain spaces for some partners. (Closed)

Created:
6 years, 4 months ago by skare_
Modified:
6 years, 4 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use CommandLine when launching Chrome from gcapi. Path may contain spaces for some partners. BUG=405614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289338

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/installer/gcapi/gcapi.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
skare_
6 years, 4 months ago (2014-08-12 22:32:22 UTC) #1
gab
lgtm
6 years, 4 months ago (2014-08-13 01:13:30 UTC) #2
skare_
The CQ bit was checked by skare@chromium.org
6 years, 4 months ago (2014-08-13 15:11:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skare@chromium.org/447673004/20001
6 years, 4 months ago (2014-08-13 15:15:19 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 19:01:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289338

Powered by Google App Engine
This is Rietveld 408576698