Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: extensions/common/features/simple_feature.cc

Issue 447673002: Don't autgrant any permissions to component extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/simple_feature.cc
diff --git a/extensions/common/features/simple_feature.cc b/extensions/common/features/simple_feature.cc
index bdf8fae78879a75cc0d3ed04dcd602a0dea15858..0f22068fc0984c315e5c265cb0cb0daf35cbb5b9 100644
--- a/extensions/common/features/simple_feature.cc
+++ b/extensions/common/features/simple_feature.cc
@@ -331,13 +331,6 @@ Feature::Availability SimpleFeature::IsAvailableToManifest(
if (IsIdInBlacklist(extension_id))
return CreateAvailability(FOUND_IN_BLACKLIST, type);
- // TODO(benwells): don't grant all component extensions.
- // See http://crbug.com/370375 for more details.
- // Component extensions can access any feature.
- // NOTE: Deliberately does not match EXTERNAL_COMPONENT.
- if (component_extensions_auto_granted_ && location == Manifest::COMPONENT)
- return CreateAvailability(IS_AVAILABLE, type);
-
if (!whitelist_.empty()) {
if (!IsIdInWhitelist(extension_id)) {
// TODO(aa): This is gross. There should be a better way to test the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698