Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: components/cronet/android/url_request_context_peer.cc

Issue 447653002: Fix Cronet mapping of Android log level into Chrome LogSeverity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Matt's comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/url_request_context_peer.h ('k') | components/cronet/android/url_request_peer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/url_request_context_peer.cc
diff --git a/components/cronet/android/url_request_context_peer.cc b/components/cronet/android/url_request_context_peer.cc
index b1e047e2929717de19379ae7052768ed0d35e5dc..84b369e4b401a23ad68350050acebcf482a9f27e 100644
--- a/components/cronet/android/url_request_context_peer.cc
+++ b/components/cronet/android/url_request_context_peer.cc
@@ -114,11 +114,9 @@ namespace cronet {
URLRequestContextPeer::URLRequestContextPeer(
URLRequestContextPeerDelegate* delegate,
- std::string user_agent,
- int logging_level) {
+ std::string user_agent) {
delegate_ = delegate;
user_agent_ = user_agent;
- logging_level_ = logging_level;
}
void URLRequestContextPeer::Initialize(
@@ -147,7 +145,7 @@ void URLRequestContextPeer::InitializeURLRequestContext(
context_.reset(context_builder.Build());
if (VLOG_IS_ON(2)) {
- net_log_observer_.reset(new NetLogObserver(logging_level_));
+ net_log_observer_.reset(new NetLogObserver());
context_->net_log()->AddThreadSafeObserver(net_log_observer_.get(),
net::NetLog::LOG_ALL_BUT_BYTES);
}
@@ -203,11 +201,9 @@ void URLRequestContextPeer::StopNetLog() {
}
void NetLogObserver::OnAddEntry(const net::NetLog::Entry& entry) {
- if (VLOG_IS_ON(2)) {
- VLOG(2) << "Net log entry: type=" << entry.type()
- << ", source=" << entry.source().type
- << ", phase=" << entry.phase();
- }
+ VLOG(2) << "Net log entry: type=" << entry.type()
+ << ", source=" << entry.source().type
+ << ", phase=" << entry.phase();
}
} // namespace cronet
« no previous file with comments | « components/cronet/android/url_request_context_peer.h ('k') | components/cronet/android/url_request_peer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698