Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/cronet/android/org_chromium_net_UrlRequestContext.cc

Issue 447653002: Fix Cronet mapping of Android log level into Chrome LogSeverity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: SetMinLogLevel instead of storing log_level in url request context. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/org_chromium_net_UrlRequestContext.cc
diff --git a/components/cronet/android/org_chromium_net_UrlRequestContext.cc b/components/cronet/android/org_chromium_net_UrlRequestContext.cc
index 689580aaaace0824b1f6c96a6c9aae7109a733af..76599f7fee7d8d5c228ebb5f66e350bf3c7ce449 100644
--- a/components/cronet/android/org_chromium_net_UrlRequestContext.cc
+++ b/components/cronet/android/org_chromium_net_UrlRequestContext.cc
@@ -9,6 +9,7 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
#include "base/json/json_reader.h"
+#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/metrics/statistics_recorder.h"
#include "base/values.h"
@@ -86,13 +87,11 @@ static jlong CreateRequestContextPeer(JNIEnv* env,
base::android::ScopedJavaLocalRef<jobject> scoped_context(env, context);
base::android::InitApplicationContext(env, scoped_context);
- int logging_level = log_level;
+ logging::SetMinLogLevel(static_cast<int>(log_level));
mmenke 2014/08/07 15:07:27 Still a bit concerned about setting this globally,
mef 2014/08/07 15:39:57 Added TODO.
// TODO(dplotnikov): set application context.
URLRequestContextPeer* peer = new URLRequestContextPeer(
- new JniURLRequestContextPeerDelegate(env, object),
- user_agent_string,
- logging_level);
+ new JniURLRequestContextPeerDelegate(env, object), user_agent_string);
peer->AddRef(); // Hold onto this ref-counted object.
peer->Initialize(context_config.Pass());
return reinterpret_cast<jlong>(peer);

Powered by Google App Engine
This is Rietveld 408576698