Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 447563003: Add initial support for compiler unit tests using GTest/GMock. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add initial support for compiler unit tests using GTest/GMock. TEST=compiler-unittests BUG=v8:3489 LOG=y R=svenpanne@chromium.org, jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -7 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/compiler-unittests/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A test/compiler-unittests/arm/instruction-selector-arm-unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A test/compiler-unittests/compiler-unittests.h View 1 chunk +60 lines, -0 lines 0 comments Download
A test/compiler-unittests/compiler-unittests.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A test/compiler-unittests/compiler-unittests.gyp View 1 chunk +51 lines, -0 lines 0 comments Download
A + test/compiler-unittests/compiler-unittests.status View 0 chunks +-1 lines, --1 lines 0 comments Download
A test/compiler-unittests/instruction-selector-unittest.h View 1 chunk +137 lines, -0 lines 0 comments Download
A test/compiler-unittests/instruction-selector-unittest.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A + test/compiler-unittests/testcfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/presubmit.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
This is still work-in-progress, just to get started.
6 years, 4 months ago (2014-08-06 12:15:01 UTC) #1
Sven Panne
lgtm
6 years, 4 months ago (2014-08-06 12:44:33 UTC) #2
jochen (gone - plz use gerrit)
i'd prefer if somebody from the compiler team would have a look at this as ...
6 years, 4 months ago (2014-08-06 12:44:35 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-06 12:52:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 22927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698