Remove inspector deadcode

Remove inspector deadcode

This patch removes some deadcode from the inspector:
1) GraphicsContextSnapshot had an unused isCertainlyOpaque bool.
2) PageDebuggerAgent had unused preprocessEventListener and preprocess.
3) The continueWithPolicyDownload instrumentation was unused.
4) Three unused function declarations have been removed from InspectorDOMAgent.

No new tests as there is no change in behavior.

R=caseq

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179851

[vsevik, 2014-08-06 07:26:39]

lgtm

https://codereview.chromium.org/447553002/diff/1/Source/core/inspector/PageDe...
File Source/core/inspector/PageDebuggerAgent.cpp (left):

https://codereview.chromium.org/447553002/diff/1/Source/core/inspector/PageDe...
Source/core/inspector/PageDebuggerAgent.cpp:150: String
PageDebuggerAgent::preprocessEventListener(LocalFrame* frame, const String&
source, const String& url, const String& functionName)
I believe this is actually the code that was intended to be run originally, so
we'd better make these methods virtual in InspectorDebuggerAgent and make them
do nothing by default.

[pdr., 2014-08-06 20:11:47]

https://codereview.chromium.org/447553002/diff/1/Source/core/inspector/PageDe...
File Source/core/inspector/PageDebuggerAgent.cpp (left):

https://codereview.chromium.org/447553002/diff/1/Source/core/inspector/PageDe...
Source/core/inspector/PageDebuggerAgent.cpp:150: String
PageDebuggerAgent::preprocessEventListener(LocalFrame* frame, const String&
source, const String& url, const String& functionName)
On 2014/08/06 07:26:39, vsevik wrote:
> I believe this is actually the code that was intended to be run originally, so
> we'd better make these methods virtual in InspectorDebuggerAgent and make them
> do nothing by default.

I see what you mean, but I think this was just added as a mistake in
https://src.chromium.org/viewvc/blink?view=rev&revision=156495. We can't make
this virtual and do nothing because we need to return something. When making
this virtual, it really will be called so we can't make them do nothing by
default.

[vsevik, 2014-08-07 13:43:36]

lgtm

https://codereview.chromium.org/447553002/diff/1/Source/core/inspector/PageDe...
File Source/core/inspector/PageDebuggerAgent.cpp (left):

https://codereview.chromium.org/447553002/diff/1/Source/core/inspector/PageDe...
Source/core/inspector/PageDebuggerAgent.cpp:150: String
PageDebuggerAgent::preprocessEventListener(LocalFrame* frame, const String&
source, const String& url, const String& functionName)
I meant that we might want to add another implementation for that in
WorkerDebuggerAgent, but after looking at it more closely, I think that we are
more likely to make an existing one more generic so that it does not depend on
the Frame, but rather on ExecutionContext instead.

[vsevik, 2014-08-07 13:43:42]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-08-07 13:44:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/447553002/1

[commit-bot: I haz the power, 2014-08-07 15:08:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-08-07 15:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-07 15:19:07]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[pdr., 2014-08-08 18:03:32]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:04:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/447553002/1

[commit-bot: I haz the power, 2014-08-08 18:22:23]

Change committed as 179851