Issue 447543003: Revert 287692 "Add a browser test for functions in notification ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 447543003: Revert 287692 "Add a browser test for functions in notification ..." (Closed)

Created:
6 years, 4 months ago by Adam Rice

Modified:
6 years, 4 months ago

Reviewers:
liyanhou

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 287692 "Add a browser test for functions in notification ..." Added a memory leak: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4658 > Add a browser test for functions in notification provider API > > Add a basic browser test for functions in notification provider API. > This is mainly to test the connection and provide a skeleton for future > tests. The functions are not fully implemented yet, and more tests will > be added as the functions are implemented. > > BUG= > > Review URL: https://codereview.chromium.org/416423006 TBR=liyanhou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287722

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -170 lines)			Patch
M	trunk/src/chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc	View	3 chunks	+9 lines, -45 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/api_test/notification_provider/basic_usage/background.js	View	1 chunk	+0 lines, -112 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/api_test/notification_provider/basic_usage/manifest.json	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 2 (0 generated)

Adam Rice

6 years, 4 months ago (2014-08-06 07:11:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r287722 (tree was closed).