Add content browser test for <optgroup> with 'display: none'

content/renderer/external_popup_menu_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "content/common/view_messages.h"
 #include "content/public/test/render_view_test.h"
 #include "content/renderer/render_view_impl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/web/WebView.h"
@@ skipping 127 matching lines @@
   EXPECT_TRUE(SimulateElementClick(kSelectID));
 
   // Select something, it causes the select to be removed from the page.
   view()->OnSelectPopupMenuItem(0);
 
   // Just to check the soundness of the test, call SimulateElementClick again.
   // It should return false as the select has been removed.
   EXPECT_FALSE(SimulateElementClick(kSelectID));
 }
 
+class ExternalPopupMenuDisplayNoneTest : public ExternalPopupMenuTest {
+  public:
+  ExternalPopupMenuDisplayNoneTest() {}
+
+  virtual void SetUp() {
+    RenderViewTest::SetUp();
+    // We need to set this explictly as RenderMain is not run.
+    blink::WebView::setUseExternalPopupMenus(true);
+
+    std::string html = "<select id='mySelect'>"
+                       "  <option value='zero'>zero</option>"
+                       "  <optgroup label='hide' style='display: none'>"
+                       "    <option value='one'>one</option>"
+                       "  </optgroup>"
+                       "  <option value='two'>two</option>"
+                       "  <option value='three'>three</option>"
+                       "  <option value='four'>four</option>"
+                       "  <option value='five'>five</option>"
+                       "</select>";
+    // Load the test page.
+    LoadHTML(html.c_str());
+
+    // Set a minimum size and give focus so simulated events work.
+    view()->webwidget()->resize(blink::WebSize(500, 500));
+    view()->webwidget()->setFocus(true);
+  }
+
+};
+
+TEST_F(ExternalPopupMenuDisplayNoneTest, SelectItem) {
+  // Click the text field once to show the popup.
+  EXPECT_TRUE(SimulateElementClick(kSelectID));
+
+  // Select index 1 item. This should select item with index 2
+  // ,skipping the item with 'display: none'

[jochen (gone - plz use gerrit), 2014/08/12 14:37:55]

nit. , on end of previous line

[spartha, 2014/08/12 14:46:34]

Done.

+  view()->OnSelectPopupMenuItem(1);
+
+  EXPECT_EQ(2,GetSelectedIndex());
+}
+
 }  // namespace content