Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 447443003: Remove custom style building for font-variant-ligatures. (Closed)

Created:
6 years, 4 months ago by andersr
Modified:
6 years, 4 months ago
Reviewers:
eae, dglazkov
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, Rik, danakj, dglazkov+blink, krit, ed+blinkwatch_opera.com, jamesr, jbroman, pdr., rwlbuis, rune+blink, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove custom style building for font-variant-ligatures. This patch uses a small, in-flight structure 'VariantLigatures' to transfer the font-variant-ligatures data during style building. This makes font style building less custom, and it removes some use of CSSValue inside FontBuilder. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -105 lines) Patch
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 2 chunks +7 lines, -81 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +46 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 3 chunks +17 lines, -4 lines 0 comments Download
M Source/platform/fonts/FontDescription.cpp View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
andersr
6 years, 4 months ago (2014-08-05 14:57:00 UTC) #1
dglazkov
LGTM!
6 years, 4 months ago (2014-08-05 14:59:51 UTC) #2
andersr
The CQ bit was checked by andersr@opera.com
6 years, 4 months ago (2014-08-05 18:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/447443003/1
6 years, 4 months ago (2014-08-05 18:23:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 00:06:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 00:51:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/15395)
6 years, 4 months ago (2014-08-06 00:51:10 UTC) #7
andersr
The CQ bit was checked by andersr@opera.com
6 years, 4 months ago (2014-08-06 07:41:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/447443003/1
6 years, 4 months ago (2014-08-06 07:41:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 08:42:15 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 09:09:45 UTC) #11
Message was sent while issue was closed.
Change committed as 179588

Powered by Google App Engine
This is Rietveld 408576698