Issue 447423002: Fix AutofillInteractiveTest tests flake on win swarming bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 447423002: Fix AutofillInteractiveTest tests flake on win swarming bots. (Closed)

Created:
6 years, 4 months ago by jam

Modified:
6 years, 4 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix AutofillInteractiveTest tests flake on win swarming bots. The tests were flaking because the preview was unexpectedly being shown at the same time as the suggestions. This happened when the mouse happened to be over the preview. BUG=364685 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288229

Patch Set 1 #

Patch Set 2 : fix clang #

Patch Set 3 : try again #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/autofill/autofill_interactive_uitest.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM! Thanks very much for tracking down this source of flakiness :)

6 years, 4 months ago (2014-08-08 03:13:07 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-08 03:17:05 UTC) #4

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jam@chromium.org/447423002/40001

Expand Messages | Collapse Messages