Issue 447403002: Move file_util_icu to base::i18n namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 447403002: Move file_util_icu to base::i18n namespace (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, benjhayden+dwatch_chromium.org, tfarina, jam, dcheng, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move file_util_icu to base::i18n namespace TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288170

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -57 lines)			Patch
M	base/i18n/file_util_icu.h	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	base/i18n/file_util_icu.cc	View	4 chunks	+17 lines, -19 lines	0 comments	Download
M	base/i18n/file_util_icu_unittest.cc	View	4 chunks	+15 lines, -10 lines	0 comments	Download
M	chrome/browser/download/save_package_file_picker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/bookmarks/bookmarks_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/shell_integration_linux.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/web_applications/web_app.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/save_package.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/directory_lister.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/directory_lister_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/base/filename_util_icu.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	printing/printed_document.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/l10n/l10n_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 4 months ago (2014-08-07 23:59:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as 288170 (presubmit successful).

Expand Messages | Collapse Messages