Issue 447343002: Revert of - Add astcbitmap to gm slides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 447343002: Revert of - Add astcbitmap to gm slides (Closed)

Created:
6 years, 4 months ago by krajcevski

Modified:
6 years, 4 months ago

Reviewers:
hal.canary, robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of - Add astcbitmap to gm slides (https://codereview.chromium.org/444093002/) Reason for revert: Breaking DM Original issue's description: > - Add astcbitmap to gm slides > - Add additional ASTC formats > - Add astc image decoder files > > Committed: https://skia.googlesource.com/skia/+/2fc05823fed4b9649338f3029cd1ba05ef49a02f TBR=reed@google.com,robertphillips@google.com,halcanary@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/7b624480654222a72e05deb1b3cc7d1849ce043d

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -483 lines)			Patch
D	gm/astcbitmap.cpp	View	1 chunk	+0 lines, -104 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/images.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkImageDecoder.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrSWMaskHelper.cpp	View	1 chunk	+13 lines, -27 lines	0 comments	Download
M	src/images/SkForceLinking.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/images/SkImageDecoder.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	src/images/SkImageDecoder_astc.cpp	View	1 chunk	+0 lines, -209 lines	0 comments	Download
M	src/utils/SkTextureCompressor.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/utils/SkTextureCompressor.cpp	View	3 chunks	+22 lines, -56 lines	0 comments	Download
M	src/utils/SkTextureCompressor_ASTC.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/ImageDecodingTest.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tests/TextureCompressionTest.cpp	View	4 chunks	+4 lines, -33 lines	0 comments	Download
M	third_party/ktx/ktx.cpp	View	1 chunk	+3 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/447343002/1

6 years, 4 months ago (2014-08-07 18:31:50 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-07 18:34:12 UTC) #3

Message was sent while issue was closed.

Change committed as 7b624480654222a72e05deb1b3cc7d1849ce043d