Issue 447333002: Address readability comments in PasswordSyncableService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 447333002: Address readability comments in PasswordSyncableService. (Closed)

Created:
6 years, 4 months ago by vasilii

Modified:
6 years, 4 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Address readability comments in PasswordSyncableService. See https://codereview.chromium.org/403323004

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+186 lines, -206 lines)			Patch
M	components/password_manager/core/browser/password_syncable_service.h	View		5 chunks	+45 lines, -34 lines	0 comments	Download
M	components/password_manager/core/browser/password_syncable_service.cc	View	1	9 chunks	+118 lines, -157 lines	0 comments	Download
M	components/password_manager/core/browser/password_syncable_service_unittest.cc	View		8 chunks	+23 lines, -15 lines	0 comments	Download

Total messages: 4 (0 generated)

vasilii

Hi Ilya, please review this changes (follow up on https://codereview.chromium.org/403323004)

6 years, 4 months ago (2014-08-07 18:14:10 UTC) #1

Ilya Sherman

Not LGTM. Please upload these changes to the original CL instead. You can use "git ...

6 years, 4 months ago (2014-08-08 16:14:01 UTC) #3

Thus, it's not supposed to be landed?