Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: test/mjsunit/fast-prototype.js

Issue 447293002: Mark as prototype only after instantiating the function (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/dictionary-properties.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 obj["x" + i] = 0; 43 obj["x" + i] = 0;
44 } 44 }
45 } 45 }
46 46
47 47
48 function DoProtoMagic(proto, set__proto__) { 48 function DoProtoMagic(proto, set__proto__) {
49 if (set__proto__) { 49 if (set__proto__) {
50 (new Sub()).__proto__ = proto; 50 (new Sub()).__proto__ = proto;
51 } else { 51 } else {
52 Sub.prototype = proto; 52 Sub.prototype = proto;
53 // Need to instantiate Sub to mark .prototype as prototype.
54 new Sub();
53 } 55 }
54 } 56 }
55 57
56 58
57 function test(use_new, add_first, set__proto__, same_map_as) { 59 function test(use_new, add_first, set__proto__, same_map_as) {
58 var proto = use_new ? new Super() : {}; 60 var proto = use_new ? new Super() : {};
59 61
60 // New object is fast. 62 // New object is fast.
61 assertTrue(%HasFastProperties(proto)); 63 assertTrue(%HasFastProperties(proto));
62 64
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 assertTrue(key == 'a'); 114 assertTrue(key == 'a');
113 break; 115 break;
114 } 116 }
115 assertFalse(%HasFastProperties(x)); 117 assertFalse(%HasFastProperties(x));
116 x.d = 4; 118 x.d = 4;
117 assertFalse(%HasFastProperties(x)); 119 assertFalse(%HasFastProperties(x));
118 for (key in x) { 120 for (key in x) {
119 assertTrue(key == 'a'); 121 assertTrue(key == 'a');
120 break; 122 break;
121 } 123 }
OLDNEW
« no previous file with comments | « test/mjsunit/dictionary-properties.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698