Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 447293002: Mark as prototype only after instantiating the function (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Mark as prototype only after instantiating the function BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22979

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M src/bootstrapper.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M src/factory.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M src/objects.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/objects.cc View 1 5 chunks +28 lines, -22 lines 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -7 lines 0 comments Download
M test/mjsunit/dictionary-properties.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/fast-prototype.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-07 15:46:00 UTC) #1
Igor Sheludko
lgtm
6 years, 4 months ago (2014-08-07 16:09:48 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-07 16:14:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 22979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698