Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 447283002: Add support for compressed alpha ktx files (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add support for compressed alpha ktx files Committed: https://skia.googlesource.com/skia/+/86bc1247d28c59f29eaf0df75c06636cab4f7d37

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -4 lines) Patch
M src/images/SkImageDecoder_ktx.cpp View 2 chunks +60 lines, -4 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
krajcevski
6 years, 4 months ago (2014-08-07 15:30:16 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/447283002/diff/1/src/images/SkImageDecoder_ktx.cpp File src/images/SkImageDecoder_ktx.cpp (right): https://codereview.chromium.org/447283002/diff/1/src/images/SkImageDecoder_ktx.cpp#newcode163 src/images/SkImageDecoder_ktx.cpp:163: Couldn't we say "ktxIsCompressed && SkTextureCompressor::kETC1_Format == ktxCompressedFormat" ...
6 years, 4 months ago (2014-08-07 16:37:29 UTC) #2
krajcevski
On 2014/08/07 16:37:29, robertphillips wrote: > lgtm > > https://codereview.chromium.org/447283002/diff/1/src/images/SkImageDecoder_ktx.cpp > File src/images/SkImageDecoder_ktx.cpp (right): > ...
6 years, 4 months ago (2014-08-07 17:48:45 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-07 17:48:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/447283002/1
6 years, 4 months ago (2014-08-07 17:49:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 17:58:58 UTC) #6
Message was sent while issue was closed.
Change committed as 86bc1247d28c59f29eaf0df75c06636cab4f7d37

Powered by Google App Engine
This is Rietveld 408576698