Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 447253002: Add a @TargetApi annotation to SelectFileDialog.onIntentCompleted. (Closed)

Created:
6 years, 4 months ago by Peter Beverloo
Modified:
6 years, 4 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add a @TargetApi annotation to SelectFileDialog.onIntentCompleted. The Intent.getClipData() method is only available in JellyBean MR2 and higher. The code does a correct version check, but the lint checker is not satisfied with this check. BUG=401333, 348912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Beverloo
+miguelg for review
6 years, 4 months ago (2014-08-07 13:14:34 UTC) #1
Miguel Garcia
lgtm
6 years, 4 months ago (2014-08-07 13:15:57 UTC) #2
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 4 months ago (2014-08-07 13:20:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/447253002/1
6 years, 4 months ago (2014-08-07 13:21:41 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:30:11 UTC) #5
Message was sent while issue was closed.
Change committed as 288074

Powered by Google App Engine
This is Rietveld 408576698