Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 447243004: Move ToolkitDelegate views impl to components/renderer_context_menu/views (Closed)

Created:
6 years, 4 months ago by oshima
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Move ToolkitDelegate views impl to components/renderer_context_menu/views I didn't move cocoa impl because that's not necessary. BUG=380438 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288281

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -72 lines) Patch
M chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 chunk +1 line, -71 lines 0 comments Download
M components/renderer_context_menu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/renderer_context_menu/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A components/renderer_context_menu/views/toolkit_delegate_views.h View 1 chunk +53 lines, -0 lines 0 comments Download
A components/renderer_context_menu/views/toolkit_delegate_views.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
sky -> please review all avi -> components/renderer_context_menu owner
6 years, 4 months ago (2014-08-07 17:34:07 UTC) #1
oshima
On 2014/08/07 17:34:07, oshima wrote: > sky -> please review all > avi -> components/renderer_context_menu ...
6 years, 4 months ago (2014-08-07 17:56:07 UTC) #2
Avi (use Gerrit)
I'm not familiar with Views code, but this looks reasonable and just moving code around, ...
6 years, 4 months ago (2014-08-07 18:33:21 UTC) #3
oshima
On 2014/08/07 18:33:21, Avi wrote: > I'm not familiar with Views code, but this looks ...
6 years, 4 months ago (2014-08-07 18:38:31 UTC) #4
sky
LGTM
6 years, 4 months ago (2014-08-07 21:11:06 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 4 months ago (2014-08-07 22:11:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/447243004/60001
6 years, 4 months ago (2014-08-07 23:00:36 UTC) #7
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 4 months ago (2014-08-07 23:58:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/447243004/110001
6 years, 4 months ago (2014-08-08 00:54:41 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 09:34:24 UTC) #10
Message was sent while issue was closed.
Change committed as 288281

Powered by Google App Engine
This is Rietveld 408576698