[Local NTP] Adding NtpDesign class to parametrizing NTP design specs

chrome/browser/search/local_ntp_source.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search/local_ntp_source.h"
 
 #include "base/json/json_string_value_serializer.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 33 matching lines @@
 const char kConfigDataFilename[] = "config.js";
 const char kLocalNTPFilename[] = "local-ntp.html";
 
 const struct Resource{
   const char* filename;
   int identifier;
   const char* mime_type;
 } kResources[] = {
   { kLocalNTPFilename, IDR_LOCAL_NTP_HTML, "text/html" },
   { "local-ntp.js", IDR_LOCAL_NTP_JS, "application/javascript" },
-  { "local-ntp-util.js", IDR_LOCAL_NTP_UTIL_JS, "application/javascript" },

[Mathieu, 2014/08/07 18:07:06]

that's probably not correct.

[huangs, 2014/08/07 20:15:20]

I was gonna add local-ntp-design.js, but realized that files that were specified
by <include ...> need not live here, so I reverted that change I did before for
local-ntp-util.js.

[Mathieu, 2014/08/07 20:50:24]

Good point, they are indeed inlined at build time.

   { kConfigDataFilename, kLocalResource, "application/javascript" },
   { "local-ntp.css", IDR_LOCAL_NTP_CSS, "text/css" },
   { "images/close_2.png", IDR_CLOSE_2, "image/png" },
   { "images/close_2_hover.png", IDR_CLOSE_2_H, "image/png" },
   { "images/close_2_active.png", IDR_CLOSE_2_P, "image/png" },
   { "images/close_2_white.png", IDR_CLOSE_2_MASK, "image/png" },
   { "images/google_logo.png", IDR_LOCAL_NTP_IMAGES_LOGO_PNG, "image/png" },
   { "images/white_google_logo.png",
     IDR_LOCAL_NTP_IMAGES_WHITE_LOGO_PNG, "image/png" },
 };
@@ skipping 163 matching lines @@
 void LocalNtpSource::SendResourceWithClass(
     int resource_id,
     const std::string& class_name,
     const content::URLDataSource::GotDataCallback& callback) {
   base::StringPiece resource_data =
       ResourceBundle::GetSharedInstance().GetRawDataResource(resource_id);
   std::string response(resource_data.as_string());
   ReplaceFirstSubstringAfterOffset(&response, 0, "{{CLASS}}", class_name);
   callback.Run(base::RefCountedString::TakeString(&response));
 }