Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 447213004: BoringSSL: switch around GYP files again. (Closed)

Created:
6 years, 4 months ago by agl
Modified:
6 years, 4 months ago
Reviewers:
hellner1, davidben
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

BoringSSL: switch around GYP files again. Any leak of boringssl.gyp (which included unittests) ends up pulling in base/ and breaks the WebRTC build. However, switching targets to boringssl_lib.gypi:boringssl breaks GYP because then there are two targets with the same name (boringssl.gyp:boringssl and boringssl_lib.gypi:boringssl). This change gives up and splits the unittests into a different .gyp file. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288251

Patch Set 1 #

Patch Set 2 : Missed adding the new file. #

Patch Set 3 : Fix unittest build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -114 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/boringssl/boringssl.gyp View 1 chunk +68 lines, -14 lines 0 comments Download
D third_party/boringssl/boringssl_lib.gypi View 1 chunk +0 lines, -80 lines 0 comments Download
A + third_party/boringssl/boringssl_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 1 2 18 chunks +18 lines, -18 lines 0 comments Download
M third_party/boringssl/update_gypi_and_asm.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
hellner1
LGTM
6 years, 4 months ago (2014-08-07 18:26:39 UTC) #1
agl
davidben as FYI.
6 years, 4 months ago (2014-08-07 18:38:24 UTC) #2
hellner1
On 2014/08/07 18:38:24, agl wrote: > davidben as FYI. Seems to pass. The android_x86_dbg seems ...
6 years, 4 months ago (2014-08-07 20:27:07 UTC) #3
agl
The CQ bit was checked by agl@chromium.org
6 years, 4 months ago (2014-08-07 20:33:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/447213004/40001
6 years, 4 months ago (2014-08-07 20:46:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 20:46:07 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-07 20:46:08 UTC) #7
davidben
On 2014/08/07 20:46:08, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 4 months ago (2014-08-07 21:20:03 UTC) #8
agl
+davidben for actual reviewer.
6 years, 4 months ago (2014-08-07 21:24:52 UTC) #9
agl
The CQ bit was checked by agl@chromium.org
6 years, 4 months ago (2014-08-07 21:25:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/447213004/40001
6 years, 4 months ago (2014-08-07 21:41:18 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 08:15:03 UTC) #12
Message was sent while issue was closed.
Change committed as 288251

Powered by Google App Engine
This is Rietveld 408576698