Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: src/compiler/instruction-selector-impl.h

Issue 447203002: Add Uint32AddWithOverflow and Uint32SubWithOverflow machine operators. Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | src/compiler/machine-node-factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction-selector-impl.h
diff --git a/src/compiler/instruction-selector-impl.h b/src/compiler/instruction-selector-impl.h
index 573c1ff41e46bbe7ee2d859c61bf7cc414351f84..24d397dce73d370c7d4a903fb7e3b06c9368fa88 100644
--- a/src/compiler/instruction-selector-impl.h
+++ b/src/compiler/instruction-selector-impl.h
@@ -270,8 +270,6 @@ class FlagsContinuation V8_FINAL {
switch (condition_) {
case kEqual:
case kNotEqual:
- case kOverflow:
- case kNotOverflow:
return;
case kSignedLessThan:
condition_ = kSignedGreaterThan;
@@ -312,6 +310,10 @@ class FlagsContinuation V8_FINAL {
case kUnorderedGreaterThan:
condition_ = kUnorderedLessThan;
return;
+ case kOverflow:
+ case kNotOverflow:
+ // We cannot commute these.
+ break;
}
UNREACHABLE();
}
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | src/compiler/machine-node-factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698