Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 447203002: Add Uint32AddWithOverflow and Uint32SubWithOverflow machine operators.

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add Uint32AddWithOverflow and Uint32SubWithOverflow machine operators. TEST=cctest/test-run-machops,cctest/test-instruction-selector-arm R=svenpanne@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+814 lines, -223 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 5 chunks +130 lines, -12 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 7 chunks +152 lines, -14 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 7 chunks +130 lines, -14 lines 0 comments Download
M src/compiler/instruction-selector.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +6 lines, -130 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/machine-node-factory.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 7 chunks +148 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-instruction-selector-arm.cc View 23 chunks +35 lines, -25 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 3 chunks +198 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-07 09:41:36 UTC) #1
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-07 09:41:54 UTC) #2
Sven Panne
6 years, 4 months ago (2014-08-07 09:55:22 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698