Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 447193004: Remove dependencies in GuestViewManager. (Closed)

Created:
6 years, 4 months ago by Xi Han
Modified:
6 years, 4 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dependencies in GuestViewManager. BUG=352290 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/guest_view/guest_view_manager.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/guest_view/guest_view_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Xi Han
6 years, 4 months ago (2014-08-07 20:07:12 UTC) #1
Fady Samuel
lgtm
6 years, 4 months ago (2014-08-07 20:16:07 UTC) #2
Xi Han
The CQ bit was checked by hanxi@chromium.org
6 years, 4 months ago (2014-08-07 20:36:27 UTC) #3
Xi Han
The CQ bit was checked by hanxi@chromium.org
6 years, 4 months ago (2014-08-07 20:40:09 UTC) #4
Xi Han
The CQ bit was unchecked by hanxi@chromium.org
6 years, 4 months ago (2014-08-07 20:44:53 UTC) #5
Xi Han
The CQ bit was checked by hanxi@chromium.org
6 years, 4 months ago (2014-08-07 21:09:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hanxi@chromium.org/447193004/1
6 years, 4 months ago (2014-08-07 21:22:36 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 01:22:43 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 01:45:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3537)
6 years, 4 months ago (2014-08-08 01:45:20 UTC) #10
Xi Han
The CQ bit was checked by hanxi@chromium.org
6 years, 4 months ago (2014-08-08 13:37:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hanxi@chromium.org/447193004/1
6 years, 4 months ago (2014-08-08 13:38:23 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 14:01:02 UTC) #13
Message was sent while issue was closed. 
Change committed as 288345

Powered by Google App Engine
This is Rietveld 408576698