Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 447193002: Add support for additional blend modes to SVGFEBlendElement (Closed)

Created:
6 years, 4 months ago by Erik Dahlström (inactive)
Modified:
6 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add support for additional blend modes to SVGFEBlendElement New modes to be supported are: overlay, color-dodge, color-burn, hard-light, soft-light, difference, exclusion, hue, saturation, color and luminosity Since the new modes don't have any corresponding IDL constants exposed on the SVGFEBlendElement interface, a mechanism is added to be able to differentiate between "internal" and "exposed" enumeration values, and reject those that are "internal-only" from being read or written through SVGAnimatedEnumeration. Test feBlend-all-modes.html evolved from test in WebKit commit http://trac.webkit.org/changeset/170433 by Dirk Schulze. BUG=389594 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -21 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEBlendElement.js View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/filters/feBlend-all-modes.html View 1 chunk +57 lines, -0 lines 0 comments Download
M Source/core/svg/SVGEnumeration.h View 4 chunks +19 lines, -7 lines 0 comments Download
M Source/core/svg/SVGEnumeration.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEBlendElement.h View 2 chunks +16 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEBlendElement.cpp View 2 chunks +37 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Erik Dahlström (inactive)
Just a rebase of https://codereview.chromium.org/435623002/. Not sure how (or if it's possible) to credit fs ...
6 years, 4 months ago (2014-08-07 09:33:45 UTC) #1
pdr.
On 2014/08/07 09:33:45, Erik Dahlström wrote: > Just a rebase of https://codereview.chromium.org/435623002/. Not sure how ...
6 years, 4 months ago (2014-08-07 17:37:23 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 4 months ago (2014-08-07 17:37:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/447193002/1
6 years, 4 months ago (2014-08-07 17:40:08 UTC) #4
commit-bot: I haz the power
Change committed as 179732
6 years, 4 months ago (2014-08-07 17:47:27 UTC) #5
Erik Dahlström (inactive)
On 2014/08/07 17:37:23, pdr wrote: ... > You can upload a patch to an existing ...
6 years, 4 months ago (2014-08-08 07:19:37 UTC) #6
krit
On 2014/08/08 07:19:37, Erik Dahlström wrote: > On 2014/08/07 17:37:23, pdr wrote: > ... > ...
6 years, 4 months ago (2014-08-08 07:24:28 UTC) #7
pdr.
6 years, 4 months ago (2014-08-12 02:27:16 UTC) #8
Message was sent while issue was closed.
On 2014/08/08 07:19:37, Erik Dahlström wrote:
> On 2014/08/07 17:37:23, pdr wrote:
> ...
> > You can upload a patch to an existing review by running "git cl issue [issue
> > number]" and then uploading with "git cl upload". I don't knoe of a way to
> > credit fs with this patch though. I agree that the chromium address
limitation
> > is ridiculous :( Can you comment on the bug about it to remind them?
> 
> Yeah, I tried that first, but it failed saying that I'm not the owner of the
> review. Are you saying it would work if I had a chromium (or google) mail
> address?

I tried this today for the rollout of this patch and it failed for me as well (I
couldn't upload a patch to your review). It looks like it is no longer possible
to upload an issue to someone else's review; probably for security reasons.

Powered by Google App Engine
This is Rietveld 408576698