Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 447183005: Use toolchain hash that's in buildtools (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : deps #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
D build/toolchain_vs2013.hash View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M build/vs_toolchain.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
scottmg
6 years, 4 months ago (2014-08-07 18:07:22 UTC) #1
iannucci
There should be a DEPS roll for buildtools in this too, right?
6 years, 4 months ago (2014-08-07 18:25:20 UTC) #2
iannucci
other than that, lgtm
6 years, 4 months ago (2014-08-07 18:25:33 UTC) #3
scottmg
On 2014/08/07 18:25:33, iannucci wrote: > other than that, lgtm Yup, added now that buildtools ...
6 years, 4 months ago (2014-08-07 18:52:29 UTC) #4
scottmg
On 2014/08/07 18:52:29, scottmg wrote: > On 2014/08/07 18:25:33, iannucci wrote: > > other than ...
6 years, 4 months ago (2014-08-07 18:54:56 UTC) #5
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-07 18:55:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/447183005/60001
6 years, 4 months ago (2014-08-07 18:59:00 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-07 23:21:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 03:33:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/4493)
6 years, 4 months ago (2014-08-08 03:33:02 UTC) #10
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-08 21:17:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/447183005/60001
6 years, 4 months ago (2014-08-08 21:19:47 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-08 22:08:30 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 00:27:34 UTC) #14
Message was sent while issue was closed. 
Change committed as 288477

Powered by Google App Engine
This is Rietveld 408576698