Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 447183003: Move OmniboxFieldTrial to components (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, tfarina, James Su, browser-components-watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move OmniboxFieldTrial to components/omnibox Move omnibox_field_trial{.cc,.h,_unittest.cc} to components/omnibox. Add components/omnibox/omnibox_switches.{cc,h} BUG=371538 TBR=sky@chromium.org for include fix under chrome/browser. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288315

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase & fix switch indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1210 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/scored_history_match.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/omnibox/omnibox_field_trial.h View 1 chunk +0 lines, -347 lines 0 comments Download
D chrome/browser/omnibox/omnibox_field_trial.cc View 1 chunk +0 lines, -443 lines 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial_unittest.cc View 1 chunk +0 lines, -381 lines 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M components/omnibox/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/omnibox/omnibox_field_trial.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/omnibox_field_trial.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + components/omnibox/omnibox_field_trial_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
A components/omnibox/omnibox_switches.h View 1 chunk +15 lines, -0 lines 0 comments Download
A components/omnibox/omnibox_switches.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-07 12:26:57 UTC) #1
Peter Kasting
RSLGTM https://codereview.chromium.org/447183003/diff/80001/components/omnibox/omnibox_switches.cc File components/omnibox/omnibox_switches.cc (right): https://codereview.chromium.org/447183003/diff/80001/components/omnibox/omnibox_switches.cc#newcode10 components/omnibox/omnibox_switches.cc:10: const char kDisableAnswersInSuggest[] = "disable-answers-in-suggest"; Nit: I suggest ...
6 years, 4 months ago (2014-08-07 22:01:13 UTC) #2
hashimoto
https://codereview.chromium.org/447183003/diff/80001/components/omnibox/omnibox_switches.cc File components/omnibox/omnibox_switches.cc (right): https://codereview.chromium.org/447183003/diff/80001/components/omnibox/omnibox_switches.cc#newcode10 components/omnibox/omnibox_switches.cc:10: const char kDisableAnswersInSuggest[] = "disable-answers-in-suggest"; On 2014/08/07 22:01:12, Peter ...
6 years, 4 months ago (2014-08-08 04:49:03 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-08 04:49:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/447183003/100001
6 years, 4 months ago (2014-08-08 04:51:34 UTC) #5
hashimoto
TBRing sky@chromium.org for include fix under chrome/browser.
6 years, 4 months ago (2014-08-08 05:10:07 UTC) #6
hashimoto
The CQ bit was unchecked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-08 05:10:12 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-08 05:10:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/447183003/100001
6 years, 4 months ago (2014-08-08 05:11:16 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 10:37:31 UTC) #10
Message was sent while issue was closed. 
Change committed as 288315

Powered by Google App Engine
This is Rietveld 408576698