Revert of Make SingleThreadProxy a SchedulerClient

Revert of Make SingleThreadProxy a SchedulerClient (https://codereview.chromium.org/134623005/)

Reason for revert:
Broke some layout tests

Original issue's description:
> Make SingleThreadProxy a SchedulerClient
> 
> This makes ui::Compositor no longer in charge of
> scheduling commits and draws, deferring it to cc::Scheduler.
> 
> Other compositors that use SingleThreadProxy are left calling composite
> synchronously and now pass a flag to indicate that this is their
> intention.  This patch doesn't remove synchronous composite, but now
> makes it mutually exclusive with scheduling.
> 
> BUG=329552, 287250
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287950

NOTRY=true
NOTREECHECKS=true
TBR=enne@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287968

[tkent, 2014-08-07 05:27:29]

Created Revert of Make SingleThreadProxy a SchedulerClient

[commit-bot: I haz the power, 2014-08-07 05:28:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/447133002/1

[commit-bot: I haz the power, 2014-08-07 05:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-07 05:28:22]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tkent, 2014-08-07 05:30:47]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-08-07 05:31:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/447133002/1

[tkent, 2014-08-07 05:45:47]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2014-08-07 05:45:55]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-08-07 05:48:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/447133002/1

[commit-bot: I haz the power, 2014-08-07 05:51:12]

Change committed as 287968

[danakj, 2014-08-07 12:31:16]

Is there somewhere else that says what tests broke and links to them?
On Aug 7, 2014 1:27 AM, <tkent@chromium.org> wrote:

> Reviewers: Ben Goodger (Google), boliu, brianderson, danakj, jamesr,
> mithro(OO till 11 Aug), piman (slow to review), sievers_OOOuntil8_15,
> simonhong, enne,
>
> Message:
> Created Revert of Make SingleThreadProxy a SchedulerClient
>
> Description:
> Revert of Make SingleThreadProxy a SchedulerClient
> (https://codereview.chromium.org/134623005/)
>
> Reason for revert:
> Broke some layout tests
>
> Original issue's description:
>
>> Make SingleThreadProxy a SchedulerClient
>>
>
>  This makes ui::Compositor no longer in charge of
>> scheduling commits and draws, deferring it to cc::Scheduler.
>>
>
>  Other compositors that use SingleThreadProxy are left calling composite
>> synchronously and now pass a flag to indicate that this is their
>> intention.  This patch doesn't remove synchronous composite, but now
>> makes it mutually exclusive with scheduling.
>>
>
>  BUG=329552, 287250
>>
>
>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>> revision=287950
>>
>
> Please review this at https://codereview.chromium.org/447133002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+478, -597 lines):
>   M android_webview/browser/hardware_renderer.h
>   M android_webview/browser/hardware_renderer.cc
>   M cc/scheduler/scheduler.h
>   M cc/scheduler/scheduler.cc
>   M cc/scheduler/scheduler_state_machine.cc
>   M cc/test/fake_layer_tree_host_client.h
>   M cc/test/layer_tree_test.h
>   M cc/test/layer_tree_test.cc
>   M cc/trees/layer_tree_host.cc
>   M cc/trees/layer_tree_host_perftest.cc
>   M cc/trees/layer_tree_host_single_thread_client.h
>   M cc/trees/layer_tree_host_unittest.cc
>   M cc/trees/layer_tree_host_unittest_animation.cc
>   M cc/trees/layer_tree_host_unittest_context.cc
>   M cc/trees/layer_tree_host_unittest_no_message_loop.cc
>   M cc/trees/layer_tree_settings.h
>   M cc/trees/layer_tree_settings.cc
>   M cc/trees/single_thread_proxy.h
>   M cc/trees/single_thread_proxy.cc
>   M cc/trees/thread_proxy.cc
>   M chrome/browser/ui/views/menu_view_drag_and_drop_test.cc
>   M content/browser/renderer_host/compositor_impl_android.cc
>   M content/public/common/content_switches.h
>   M content/public/common/content_switches.cc
>   M content/renderer/gpu/render_widget_compositor.h
>   M content/renderer/gpu/render_widget_compositor.cc
>   M content/renderer/render_widget.h
>   M content/renderer/render_widget.cc
>   M content/shell/renderer/test_runner/web_test_proxy.cc
>   M content/test/web_layer_tree_view_impl_for_testing.h
>   M ui/compositor/compositor.h
>   M ui/compositor/compositor.cc
>   M ui/compositor/layer_unittest.cc
>   M ui/compositor/test/draw_waiter_for_test.h
>   M ui/compositor/test/draw_waiter_for_test.cc
>   M ui/compositor/test/test_compositor_host_mac.mm
>   M ui/compositor/test/test_compositor_host_ozone.cc
>   M ui/compositor/test/test_compositor_host_win.cc
>   M ui/compositor/test/test_compositor_host_x11.cc
>   M ui/snapshot/snapshot_aura_unittest.cc
>   M ui/views/view_unittest.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-08-07 12:38:14]

Ooh I found it. Sorry and thanks!
On Aug 7, 2014 8:31 AM, "Dana Jansens" <danakj@chromium.org> wrote:

> Is there somewhere else that says what tests broke and links to them?
> On Aug 7, 2014 1:27 AM, <tkent@chromium.org> wrote:
>
>> Reviewers: Ben Goodger (Google), boliu, brianderson, danakj, jamesr,
>> mithro(OO till 11 Aug), piman (slow to review), sievers_OOOuntil8_15,
>> simonhong, enne,
>>
>> Message:
>> Created Revert of Make SingleThreadProxy a SchedulerClient
>>
>> Description:
>> Revert of Make SingleThreadProxy a SchedulerClient
>> (https://codereview.chromium.org/134623005/)
>>
>> Reason for revert:
>> Broke some layout tests
>>
>> Original issue's description:
>>
>>> Make SingleThreadProxy a SchedulerClient
>>>
>>
>>  This makes ui::Compositor no longer in charge of
>>> scheduling commits and draws, deferring it to cc::Scheduler.
>>>
>>
>>  Other compositors that use SingleThreadProxy are left calling composite
>>> synchronously and now pass a flag to indicate that this is their
>>> intention.  This patch doesn't remove synchronous composite, but now
>>> makes it mutually exclusive with scheduling.
>>>
>>
>>  BUG=329552, 287250
>>>
>>
>>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>>> revision=287950
>>>
>>
>> Please review this at https://codereview.chromium.org/447133002/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files (+478, -597 lines):
>>   M android_webview/browser/hardware_renderer.h
>>   M android_webview/browser/hardware_renderer.cc
>>   M cc/scheduler/scheduler.h
>>   M cc/scheduler/scheduler.cc
>>   M cc/scheduler/scheduler_state_machine.cc
>>   M cc/test/fake_layer_tree_host_client.h
>>   M cc/test/layer_tree_test.h
>>   M cc/test/layer_tree_test.cc
>>   M cc/trees/layer_tree_host.cc
>>   M cc/trees/layer_tree_host_perftest.cc
>>   M cc/trees/layer_tree_host_single_thread_client.h
>>   M cc/trees/layer_tree_host_unittest.cc
>>   M cc/trees/layer_tree_host_unittest_animation.cc
>>   M cc/trees/layer_tree_host_unittest_context.cc
>>   M cc/trees/layer_tree_host_unittest_no_message_loop.cc
>>   M cc/trees/layer_tree_settings.h
>>   M cc/trees/layer_tree_settings.cc
>>   M cc/trees/single_thread_proxy.h
>>   M cc/trees/single_thread_proxy.cc
>>   M cc/trees/thread_proxy.cc
>>   M chrome/browser/ui/views/menu_view_drag_and_drop_test.cc
>>   M content/browser/renderer_host/compositor_impl_android.cc
>>   M content/public/common/content_switches.h
>>   M content/public/common/content_switches.cc
>>   M content/renderer/gpu/render_widget_compositor.h
>>   M content/renderer/gpu/render_widget_compositor.cc
>>   M content/renderer/render_widget.h
>>   M content/renderer/render_widget.cc
>>   M content/shell/renderer/test_runner/web_test_proxy.cc
>>   M content/test/web_layer_tree_view_impl_for_testing.h
>>   M ui/compositor/compositor.h
>>   M ui/compositor/compositor.cc
>>   M ui/compositor/layer_unittest.cc
>>   M ui/compositor/test/draw_waiter_for_test.h
>>   M ui/compositor/test/draw_waiter_for_test.cc
>>   M ui/compositor/test/test_compositor_host_mac.mm
>>   M ui/compositor/test/test_compositor_host_ozone.cc
>>   M ui/compositor/test/test_compositor_host_win.cc
>>   M ui/compositor/test/test_compositor_host_x11.cc
>>   M ui/snapshot/snapshot_aura_unittest.cc
>>   M ui/views/view_unittest.cc
>>
>>
>>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.